Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DotNetAliases: Extract methods into a separate partial class #4398

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

Marusyk
Copy link
Contributor

@Marusyk Marusyk commented Nov 16, 2024

discussion
This pull request refactors the DotNetAliases class by extracting its methods into separate partial classes. The methods have been moved to individual files based on their functionality.

By refactoring the code into separate partial classes, we address these issues and create a more modular and maintainable codebase.

The original DotNetAliases.cs file had become too large and difficult to manage. By splitting the methods into separate partial classes, we achieve the following benefits:

  • improved code organization: Each file now contains methods related to a specific functionality, making it easier to navigate, understand, fix.
  • enhanced maintainability: Smaller, focused files are easier to maintain and modify. This reduces the risk of merge conflicts and makes it simpler to track changes.
  • better readability: Developers can quickly locate the methods they need without sifting through a large file.

Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marusyk
Copy link
Contributor Author

Marusyk commented Nov 18, 2024

#4392 should be merged first, then I'll add Remove to DotNetAliases .Sln.cs

@devlead
Copy link
Member

devlead commented Nov 23, 2024

@Marusyk #4392 is now merged.

@Marusyk
Copy link
Contributor Author

Marusyk commented Nov 23, 2024

Updated

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 124704e into cake-build:develop Nov 25, 2024
16 checks passed
@devlead
Copy link
Member

devlead commented Nov 25, 2024

@Marusyk your changes have been merged, thanks for your contribution 👍

@Marusyk Marusyk deleted the marusyk/dotnetalias-partial branch November 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor DotNetAliases: Extract methods into a separate partial class
3 participants